From: Wouter Wijngaards <wouter@nlnetlabs.nl>
Date: Thu, 29 Nov 2018 14:39:26 +0000 (+0000)
Subject: - Remove clang analysis warnings.
X-Git-Tag: release-1.9.0rc1~81
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c1c1cd97e74cea9a66f02ecb534809ce783603d0;p=thirdparty%2Funbound.git

- Remove clang analysis warnings.


git-svn-id: file:///svn/unbound/trunk@4998 be551aaa-1e26-0410-a405-d3ace91eadb9
---

diff --git a/doc/Changelog b/doc/Changelog
index 3a121988c..bf96a59f4 100644
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -5,6 +5,7 @@
 	- Fix that unbound-checkconf does not complains if the config file
 	  is not placed inside the chroot.
 	- Refuse to start with no ports.
+	- Remove clang analysis warnings.
 
 28 November 2018: Wouter
 	- Fix leak in chroot fix for auth-zone.
diff --git a/testdata/clang-analysis.tdir/clang-analysis.test b/testdata/clang-analysis.tdir/clang-analysis.test
index d8585d62d..09c935860 100644
--- a/testdata/clang-analysis.tdir/clang-analysis.test
+++ b/testdata/clang-analysis.tdir/clang-analysis.test
@@ -59,6 +59,7 @@ for x in cachedb/*.c daemon/*.c dns64/*.c $DNSCRYPT_SRC $DNSTAP_SRC edns-subnet/
 	if test "$x" = "util/configlexer.c"; then continue; fi
 	if test "$x" = "util/configparser.c"; then continue; fi
 	if test "$x" = "testcode/signit.c"; then continue; fi
+	if test "$x" = "compat/reallocarray.c"; then continue; fi
 	echo clang --analyze $CPPFLAGS $x
 	plist=`basename $x .c`.plist
 	rm -rf $plist
diff --git a/validator/val_neg.c b/validator/val_neg.c
index c494a6be6..4c08e6bbc 100644
--- a/validator/val_neg.c
+++ b/validator/val_neg.c
@@ -235,6 +235,7 @@ void neg_delete_data(struct val_neg_cache* neg, struct val_neg_data* el)
 
 	/* remove it from the lru list */
 	neg_lru_remove(neg, el);
+	log_assert(neg->first != el && neg->last != el);
 	
 	/* go up the tree and reduce counts */
 	p = el;