From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 31 Mar 2007 21:10:05 +0000 (+0000)
Subject: Pointless to check for non-NULL pointers that already have been dereferenced
X-Git-Tag: curl-7_16_2~70
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c1f117700ac3dcca2bb6e3e8cde4535d4a6ad1de;p=thirdparty%2Fcurl.git

Pointless to check for non-NULL pointers that already have been dereferenced
and they have to be non-NULL long before this check.
CID 22 in the coverity.com scan
---

diff --git a/lib/ssluse.c b/lib/ssluse.c
index 8265f13b3d..d96ee13bf6 100644
--- a/lib/ssluse.c
+++ b/lib/ssluse.c
@@ -431,7 +431,7 @@ int cert_stuff(struct connectdata *conn,
 #ifdef HAVE_OPENSSL_ENGINE_H
       {                         /* XXXX still needs some work */
         EVP_PKEY *priv_key = NULL;
-        if(conn && conn->data && conn->data->state.engine) {
+        if(data->state.engine) {
 #ifdef HAVE_ENGINE_LOAD_FOUR_ARGS
           UI_METHOD *ui_method = UI_OpenSSL();
 #endif
@@ -441,7 +441,7 @@ int cert_stuff(struct connectdata *conn,
           }
           /* the typecast below was added to please mingw32 */
           priv_key = (EVP_PKEY *)
-            ENGINE_load_private_key(conn->data->state.engine,key_file,
+            ENGINE_load_private_key(data->state.engine,key_file,
 #ifdef HAVE_ENGINE_LOAD_FOUR_ARGS
                                     ui_method,
 #endif