From: Martin Liska <mliska@suse.cz>
Date: Wed, 17 Aug 2022 07:38:17 +0000 (+0200)
Subject: debuginfod: fix http_requests_total{type="debuginfo"} when dwz is used
X-Git-Tag: elfutils-0.188~37
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c1feb2717ff72adc963360e00ce70a9ed2d8e613;p=thirdparty%2Felfutils.git

debuginfod: fix http_requests_total{type="debuginfo"} when dwz is used

When dwarf_extract_source_paths is called, it can call handle_buildid
when a rpm file used dwz. Ignore such internal request in
http_requests_total statistics.

Signed-off-by: Martin Liska <mliska@suse.cz>
---

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 366a4a09d..3e2dd9ef9 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -1921,7 +1921,8 @@ handle_buildid (MHD_Connection* conn,
     throw reportable_exception("invalid artifacttype");
   }
 
-  inc_metric("http_requests_total", "type", artifacttype);
+  if (conn != 0)
+    inc_metric("http_requests_total", "type", artifacttype);
   
   if (atype_code == "S" && suffix == "")
      throw reportable_exception("invalid source suffix");
@@ -2083,7 +2084,8 @@ and will not query the upstream servers");
 
   if (fd >= 0)
     {
-      inc_metric ("http_responses_total","result","upstream");
+      if (conn != 0)
+	inc_metric ("http_responses_total","result","upstream");
       struct stat s;
       int rc = fstat (fd, &s);
       if (rc == 0)