From: Elia Pinto Date: Tue, 22 Dec 2015 14:10:29 +0000 (+0100) Subject: git-gui/po/glossary/txt-to-pot.sh: use the $( ... ) construct for command substitution X-Git-Tag: gitgui-0.21.0~9^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c217e26c9df0a701a3ba4be0654bedf8c328c36b;p=thirdparty%2Fgit.git git-gui/po/glossary/txt-to-pot.sh: use the $( ... ) construct for command substitution The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto Reviewed-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Pat Thoyts --- diff --git a/po/glossary/txt-to-pot.sh b/po/glossary/txt-to-pot.sh index 49bf7c5365..8249915d3c 100755 --- a/po/glossary/txt-to-pot.sh +++ b/po/glossary/txt-to-pot.sh @@ -11,7 +11,7 @@ if [ $# -eq 0 ] then cat < git-gui-glossary.pot +Usage: $(basename $0) git-gui-glossary.txt > git-gui-glossary.pot ! exit 1; fi @@ -33,7 +33,7 @@ cat <\n" "Language-Team: LANGUAGE \n"