From: Yang Erkun <yangerkun@huawei.com>
Date: Wed, 25 Dec 2024 06:59:06 +0000 (+0800)
Subject: nfsd: no need get cache ref when protected by rcu
X-Git-Tag: v6.14-rc1~64^2~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c224edca7af028828e2ad866b61d731b5e72b46d;p=thirdparty%2Fkernel%2Flinux.git

nfsd: no need get cache ref when protected by rcu

rcu_read_lock/rcu_read_unlock has already provide protection for the
pointer we will reference when we call e_show. Therefore, there is no
need to obtain a cache reference to help protect cache_head.
Additionally, the .put such as expkey_put/svc_export_put will invoke
dput, which can sleep and break rcu. Stop get cache reference to fix
them all.

Fixes: ae74136b4bb6 ("SUNRPC: Allow cache lookups to use RCU protection rather than the r/w spinlock")
Suggested-by: NeilBrown <neilb@suse.de>
Signed-off-by: Yang Erkun <yangerkun@huawei.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index aa4712362b3b3..c6168bccfb6c6 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -1425,13 +1425,9 @@ static int e_show(struct seq_file *m, void *p)
 		return 0;
 	}
 
-	if (!cache_get_rcu(&exp->h))
+	if (cache_check_rcu(cd, &exp->h, NULL))
 		return 0;
 
-	if (cache_check(cd, &exp->h, NULL))
-		return 0;
-
-	exp_put(exp);
 	return svc_export_show(m, cd, cp);
 }