From: Chandra Pratap Date: Wed, 21 Aug 2024 12:30:55 +0000 (+0530) Subject: t-reftable-block: use reftable_record_key() instead of strbuf_addstr() X-Git-Tag: v2.47.0-rc0~83^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c25cbcd352c5831a1270b57104ecb6c0e6789a0c;p=thirdparty%2Fgit.git t-reftable-block: use reftable_record_key() instead of strbuf_addstr() In the current testing setup, the record key required for many block iterator functions is manually stored in a strbuf struct and then passed to these functions. This is not ideal when there exists a dedicated function to encode a record's key into a strbuf, namely reftable_record_key(). Use this function instead of manual encoding. Mentored-by: Patrick Steinhardt Mentored-by: Christian Couder Signed-off-by: Chandra Pratap Signed-off-by: Junio C Hamano --- diff --git a/t/unit-tests/t-reftable-block.c b/t/unit-tests/t-reftable-block.c index b106d3c1e4..5887e9205d 100644 --- a/t/unit-tests/t-reftable-block.c +++ b/t/unit-tests/t-reftable-block.c @@ -83,8 +83,7 @@ static void t_block_read_write(void) for (i = 0; i < N; i++) { struct block_iter it = BLOCK_ITER_INIT; - strbuf_reset(&want); - strbuf_addstr(&want, recs[i].u.ref.refname); + reftable_record_key(&recs[i], &want); ret = block_iter_seek_key(&it, &br, &want); check_int(ret, ==, 0);