From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 22 Oct 2021 08:55:43 +0000 (+0200)
Subject: submodule--helper: fix small memory leaks
X-Git-Tag: v2.34.0-rc0~15^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c270b055d94b643b0ac8bcb390b82330aee01a34;p=thirdparty%2Fgit.git

submodule--helper: fix small memory leaks

Add a missing strbuf_release() and a clear_pathspec() to the
submodule--helper.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 6298cbdd4e..a157656a48 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -3220,6 +3220,7 @@ static void die_on_index_match(const char *path, int force)
 		}
 		free(ps_matched);
 	}
+	clear_pathspec(&ps);
 }
 
 static void die_on_repo_without_commits(const char *path)
@@ -3231,6 +3232,7 @@ static void die_on_repo_without_commits(const char *path)
 		if (resolve_gitlink_ref(path, "HEAD", &oid) < 0)
 			die(_("'%s' does not have a commit checked out"), path);
 	}
+	strbuf_release(&sb);
 }
 
 static int module_add(int argc, const char **argv, const char *prefix)