From: Laurent Pinchart Date: Tue, 23 Mar 2021 00:09:53 +0000 (+0200) Subject: drm: rcar-du: Don't put reference to drm_device in rcar_du_remove() X-Git-Tag: v5.15-rc1~148^2~18^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c29b6b0b126e9ee69a5d6339475e831a149295bd;p=thirdparty%2Flinux.git drm: rcar-du: Don't put reference to drm_device in rcar_du_remove() The reference to the drm_device that was acquired by devm_drm_dev_alloc() is released automatically by the devres infrastructure. It must not be released manually, as that causes a reference underflow.. Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 9788286813131..44b18fa525f03 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); - drm_dev_put(ddev); - return 0; }