From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 17 Mar 2023 10:05:26 +0000 (+0000)
Subject: build: Drop check-libraries script
X-Git-Tag: 0.9.29~294
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c30dd00cea3211f9742beb9a0f639294c9c3d647;p=pakfire.git

build: Drop check-libraries script

This is now covered by the new builtin FHS check.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/Makefile.am b/Makefile.am
index 1ec548fca..713898fb3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -724,7 +724,6 @@ dist_scripts_SCRIPTS = \
 	src/scripts/check-hardening \
 	src/scripts/check-include \
 	src/scripts/check-interpreters \
-	src/scripts/check-libraries \
 	src/scripts/check-rpaths \
 	src/scripts/check-unsafe-files \
 	src/scripts/compress-man-pages \
diff --git a/src/libpakfire/build.c b/src/libpakfire/build.c
index e481ede09..9887f3480 100644
--- a/src/libpakfire/build.c
+++ b/src/libpakfire/build.c
@@ -1323,7 +1323,6 @@ ERROR:
 
 static const char* post_build_scripts[] = {
 	"check-unsafe-files",
-	"check-libraries",
 	"check-rpaths",
 	"check-buildroot",
 	"check-include",
diff --git a/src/scripts/check-libraries b/src/scripts/check-libraries
deleted file mode 100644
index 53ad370ca..000000000
--- a/src/scripts/check-libraries
+++ /dev/null
@@ -1,76 +0,0 @@
-#!/bin/bash
-###############################################################################
-#                                                                             #
-# Pakfire - The IPFire package management system                              #
-# Copyright (C) 2021 Pakfire development team                                 #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-###############################################################################
-
-error() {
-	echo "$@" >&2
-}
-
-main() {
-	local buildroot="${1}"
-	shift
-
-	# Check if BUILDROOT exists
-	if [ ! -d "${buildroot}" ]; then
-		error "BUILDROOT does not exist"
-		return 1
-	fi
-
-	# Fetch the architecture
-	local arch="$(uname -m)"
-
-	case "${arch}" in
-		# Fall through on these architectures
-		aarch64|x86_64)
-			;;
-
-		# This check isn't relevant
-		*)
-			return 0
-			;;
-	esac
-
-	local files=()
-
-	local file
-	for file in $(find "${buildroot}/usr/lib" -maxdepth 1 -name "*.so*" 2>/dev/null); do
-		# Ignore any non-ELF files
-		if ! file "${file}" | grep -q "ELF"; then
-			continue
-		fi
-
-		files+=( "${file}" )
-	done
-
-	# Log errors
-	if [ "${#files[@]}" -gt 0 ]; then
-		error "Libraries are not allowed to be installed in /usr/lib"
-		local file
-		for file in ${files[@]}; do
-			error "  ${file/${buildroot}/}"
-		done
-
-		return 1
-	fi
-
-	return 0
-}
-
-main "$@" || exit $?