From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Thu, 23 Jan 2020 07:57:26 +0000 (+0200)
Subject: doveadm: doveadm-sis - Ensure buf2 is not overrun
X-Git-Tag: 2.3.10~107
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c319ff612d86df69c7c58805ef22d97db6192d8a;p=thirdparty%2Fdovecot%2Fcore.git

doveadm: doveadm-sis - Ensure buf2 is not overrun

Satisfies static analysers.
---

diff --git a/src/doveadm/doveadm-sis.c b/src/doveadm/doveadm-sis.c
index e681b8fde0..bc6444ebfa 100644
--- a/src/doveadm/doveadm-sis.c
+++ b/src/doveadm/doveadm-sis.c
@@ -65,6 +65,7 @@ file_contents_equal(const char *path1, const char *path2, ino_t *path2_inode_r)
 		int ret2;
 
 		while ((ret1 = read(fd1, buf1, sizeof(buf1))) > 0) {
+			i_assert((size_t)ret1 <= sizeof(buf2));
 			if ((ret2 = read_full(fd2, buf2, ret1)) <= 0) {
 				if (ret2 < 0)
 					i_error("read(%s) failed: %m", path2);