From: Evgeny Novikov <novikov@ispras.ru>
Date: Fri, 30 Jul 2021 16:53:33 +0000 (+0300)
Subject: HID: thrustmaster: Fix memory leak in thrustmaster_interrupts()
X-Git-Tag: v5.15-rc1~110^2~2^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3800eed22d21c66912b4461a403b4448ed88d95;p=thirdparty%2Fkernel%2Flinux.git

HID: thrustmaster: Fix memory leak in thrustmaster_interrupts()

thrustmaster_interrupts() does not free memory for send_buf when
usb_interrupt_msg() fails. This is fixed by the given patch.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index 9cb4248f95afd..d44550aa88057 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -173,6 +173,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev)
 
 		if (ret) {
 			hid_err(hdev, "setup data couldn't be sent\n");
+			kfree(send_buf);
 			return;
 		}
 	}