From: Mark Bloch <mbloch@nvidia.com>
Date: Tue, 15 Mar 2022 10:45:00 +0000 (+0000)
Subject: net/mlx5: fs, jump to exit point and don't fall through
X-Git-Tag: v5.19-rc1~159^2~197^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3ae3a9cfe2f3cfdea5a990fa96e23aee343fdb9;p=thirdparty%2Flinux.git

net/mlx5: fs, jump to exit point and don't fall through

For code clarity and to prevent future bugs make sure to jump
to the exit point once done handling that specific type.
This aligns the code with the rest logic in the function.

Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Reviewed-by: Maor Gottlieb <maorg@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index ae83962fc5fc4..e282d80f1fd23 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -570,6 +570,7 @@ static void del_sw_hw_rule(struct fs_node *node)
 		--fte->dests_size;
 		fte->modify_mask |=
 			BIT(MLX5_SET_FTE_MODIFY_ENABLE_MASK_DESTINATION_LIST);
+		goto out;
 	}
 out:
 	kfree(rule);