From: Willy Tarreau <w@1wt.eu>
Date: Tue, 7 May 2019 12:44:41 +0000 (+0200)
Subject: MINOR: mux-h2: remove useless test on stream ID vs last in wake function
X-Git-Tag: v2.0-dev3~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3b1183f57250f8e969b22dc4718c63e601d685f;p=thirdparty%2Fhaproxy.git

MINOR: mux-h2: remove useless test on stream ID vs last in wake function

h2_wake_some_streams() first looks up streams whose IDs are greater than
or equal to last+1, then checks if the id is lower than or equal to last,
which by definition will never match. Let's remove this confusing leftover
from ancient code.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index c4588eec52..40ff11a7e7 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -1464,8 +1464,6 @@ static void h2_wake_some_streams(struct h2c *h2c, int last, uint32_t flags)
 	node = eb32_lookup_ge(&h2c->streams_by_id, last + 1);
 	while (node) {
 		h2s = container_of(node, struct h2s, by_id);
-		if (h2s->id <= last)
-			break;
 		node = eb32_next(node);
 		h2s_wake_one_stream(h2s, flags);
 	}