From: Guinevere Larsen <guinevere@redhat.com>
Date: Mon, 25 Nov 2024 17:34:31 +0000 (-0300)
Subject: gdb/testsuite: make gdb.reverse/i386-avx-reverse.exp require avx
X-Git-Tag: gdb-16-branchpoint~204
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3b15d468c106ed70954e863c595f857657bd8f2;p=thirdparty%2Fbinutils-gdb.git

gdb/testsuite: make gdb.reverse/i386-avx-reverse.exp require avx

The test gdb.reverse/i386-avx-reverse.exp was assuming that if the CPU
was like x86, it would have AVX instructions because I didn't know how
to check for AVX instruction support explicitly.  This commit updates
that to use the pre-existing TCL proc have_avx.

Also update the comment at the top of the test, since it was a copy of a
different test.

Approved-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
index 6d8990067f2..cc920d3a2f3 100644
--- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
@@ -16,15 +16,12 @@
 # This file is part of the gdb testsuite.
 
 #
-# This test tests some i386 general instructions for reverse execution.
+# This test tests i386 AVX instructions for reverse execution.  This
+# is supposed to test all supported instructions eventually.
 #
 
 require supports_reverse
-
-if {![istarget "*86*-*linux*"]} {
-    verbose "Skipping i386 reverse tests."
-    return
-}
+require have_avx
 
 # TODO: this is the case because I used xmm15 all over the test.
 # Some parts of the test require xmm15 to validate some code paths, but