From: Xiang Chen Date: Sat, 16 Apr 2022 07:38:15 +0000 (+0800) Subject: hw/arm/smmuv3: Pass the actual perm to returned IOMMUTLBEntry in smmuv3_translate() X-Git-Tag: v7.1.0-rc0~133^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3ca7d56c4790c2223122f7e84b71161cd36dbce;p=thirdparty%2Fqemu.git hw/arm/smmuv3: Pass the actual perm to returned IOMMUTLBEntry in smmuv3_translate() It always calls the IOMMU MR translate() callback with flag=IOMMU_NONE in memory_region_iommu_replay(). Currently, smmuv3_translate() return an IOMMUTLBEntry with perm set to IOMMU_NONE even if the translation success, whereas it is expected to return the actual permission set in the table entry. So pass the actual perm to returned IOMMUTLBEntry in the table entry. Signed-off-by: Xiang Chen Reviewed-by: Eric Auger Message-id: 1650094695-121918-1-git-send-email-chenxiang66@hisilicon.com Signed-off-by: Peter Maydell --- diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 674623aabea..707eb430c23 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -760,7 +760,7 @@ epilogue: qemu_mutex_unlock(&s->mutex); switch (status) { case SMMU_TRANS_SUCCESS: - entry.perm = flag; + entry.perm = cached_entry->entry.perm; entry.translated_addr = cached_entry->entry.translated_addr + (addr & cached_entry->entry.addr_mask); entry.addr_mask = cached_entry->entry.addr_mask;