From: Fabio Estevam Date: Sun, 27 Aug 2017 16:30:38 +0000 (-0300) Subject: [media] ov2640: Check the return value from clk_prepare_enable() X-Git-Tag: v4.15-rc1~91^2~231 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3d14780249814f200317cfed1e5d288aeefb528;p=thirdparty%2Fkernel%2Flinux.git [media] ov2640: Check the return value from clk_prepare_enable() clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c index e6cbe01bc4cf9..5f013c8cbdb5a 100644 --- a/drivers/media/i2c/ov2640.c +++ b/drivers/media/i2c/ov2640.c @@ -1108,7 +1108,9 @@ static int ov2640_probe(struct i2c_client *client, priv->clk = devm_clk_get(&client->dev, "xvclk"); if (IS_ERR(priv->clk)) return PTR_ERR(priv->clk); - clk_prepare_enable(priv->clk); + ret = clk_prepare_enable(priv->clk); + if (ret) + return ret; } ret = ov2640_probe_dt(client, priv);