From: Mike Bayer Date: Tue, 13 May 2025 15:28:25 +0000 (-0400) Subject: remove __getattr__ from root X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c3f1ea62286a0b038482437923c4d1c53d668dcb;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git remove __getattr__ from root Removed ``__getattr__()`` rule from ``sqlalchemy/__init__.py`` that appeared to be trying to correct for a previous typographical error in the imports. This rule interferes with type checking and is removed. Fixes: #12588 Change-Id: I682b1f3c13b842d6f43ed02d28d9774b55477516 --- diff --git a/doc/build/changelog/unreleased_20/12588.rst b/doc/build/changelog/unreleased_20/12588.rst new file mode 100644 index 0000000000..2d30a768f7 --- /dev/null +++ b/doc/build/changelog/unreleased_20/12588.rst @@ -0,0 +1,8 @@ +.. change:: + :tags: bug, typing + :tickets: 12588 + + Removed ``__getattr__()`` rule from ``sqlalchemy/__init__.py`` that + appeared to be trying to correct for a previous typographical error in the + imports. This rule interferes with type checking and is removed. + diff --git a/lib/sqlalchemy/__init__.py b/lib/sqlalchemy/__init__.py index 53c1dbb7d1..be099c29b3 100644 --- a/lib/sqlalchemy/__init__.py +++ b/lib/sqlalchemy/__init__.py @@ -279,14 +279,3 @@ def __go(lcls: Any) -> None: __go(locals()) - - -def __getattr__(name: str) -> Any: - if name == "SingleonThreadPool": - _util.warn_deprecated( - "SingleonThreadPool was a typo in the v2 series. " - "Please use the correct SingletonThreadPool name.", - "2.0.24", - ) - return SingletonThreadPool - raise AttributeError(f"module {__name__!r} has no attribute {name!r}")