From: Christoph Hellwig Date: Fri, 19 Jul 2024 04:10:24 +0000 (+0200) Subject: dma-mapping: don't return errors from dma_set_min_align_mask X-Git-Tag: v6.12-rc1~125^2~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c42a01264ba1497eb3193c08ff3c2656d98250a6;p=thirdparty%2Fkernel%2Flinux.git dma-mapping: don't return errors from dma_set_min_align_mask A NULL dev->dma_parms indicates either a bus that is not DMA capable or grave bug in the implementation of the bus code. There isn't much the driver can do in terms of error handling for either case, so just warn and continue as DMA operations will fail anyway. Signed-off-by: Christoph Hellwig Reviewed-by: Robin Murphy Reviewed-by: Martin K. Petersen --- diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index f693aafe221f2..cfd6bafec3f94 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -575,13 +575,12 @@ static inline unsigned int dma_get_min_align_mask(struct device *dev) return 0; } -static inline int dma_set_min_align_mask(struct device *dev, +static inline void dma_set_min_align_mask(struct device *dev, unsigned int min_align_mask) { if (WARN_ON_ONCE(!dev->dma_parms)) - return -EIO; + return; dev->dma_parms->min_align_mask = min_align_mask; - return 0; } #ifndef dma_get_cache_alignment