From: Arnd Bergmann Date: Tue, 10 Oct 2017 09:20:11 +0000 (+0200) Subject: ASoC: dapm: mark 'snd_soc_dapm_free_kcontrol' as static X-Git-Tag: v4.15-rc1~118^2~1^2~15^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c42c5ac4269bf8c0aa7ef2f4bdf328a12b03f65f;p=thirdparty%2Flinux.git ASoC: dapm: mark 'snd_soc_dapm_free_kcontrol' as static The newly introduced function is declared as globally visible, but is not declared in a header, causing a warning 'make W=1' or 'make C=1': sound/soc/soc-dapm.c:3782:1: warning: symbol 'snd_soc_dapm_free_kcontrol' was not declared. Should it be static? The suggestion to make it static seems appropriate here, so let's do that. Fixes: 19ad683abc85 ("ASoC: dapm: Avoid creating kcontrol for params") Signed-off-by: Arnd Bergmann Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 12eb74d5f5c12..d674589e82e57 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3778,7 +3778,7 @@ static int snd_soc_dapm_dai_link_put(struct snd_kcontrol *kcontrol, return 0; } -void +static void snd_soc_dapm_free_kcontrol(struct snd_soc_card *card, unsigned long *private_value, int num_params,