From: Haotian Zhang <vulab@iscas.ac.cn>
Date: Mon, 29 Sep 2025 11:12:29 +0000 (+0800)
Subject: media: cec: Fix debugfs leak on bus_register() failure
X-Git-Tag: v6.19-rc1~159^2~224
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c43bcd2b2aa3c2ca9d2433c3990ecbc2c47d10eb;p=thirdparty%2Fkernel%2Flinux.git

media: cec: Fix debugfs leak on bus_register() failure

In cec_devnode_init(), the debugfs directory created with
debugfs_create_dir() is not removed if bus_register() fails.
This leaves a stale "cec" entry in debugfs and prevents
proper module reloading.

Fix this by removing the debugfs directory in the error path.

Fixes: a56960e8b406 ("[media] cec: add HDMI CEC framework (core)")
Cc: stable@vger.kernel.org
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
---

diff --git a/drivers/media/cec/core/cec-core.c b/drivers/media/cec/core/cec-core.c
index d7259599029f8..dd6e24a0899bd 100644
--- a/drivers/media/cec/core/cec-core.c
+++ b/drivers/media/cec/core/cec-core.c
@@ -421,6 +421,7 @@ static int __init cec_devnode_init(void)
 
 	ret = bus_register(&cec_bus_type);
 	if (ret < 0) {
+		debugfs_remove_recursive(top_cec_dir);
 		unregister_chrdev_region(cec_dev_t, CEC_NUM_DEVICES);
 		pr_warn("cec: bus_register failed\n");
 		return -EIO;