From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Fri, 30 Jul 2021 17:57:01 +0000 (+0200)
Subject: qos.cgi: Fix truncated status output
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c4522a1764f8c965bf85fb8ff3314a03b9ec5da1;p=people%2Fms%2Fipfire-2.x.git

qos.cgi: Fix truncated status output

In the past only the fist line of the status output has been passed
to the cleanhtml() function and displayed. Now the whole output will be
converted to a string, cleaned and displyed on the WUI again.

Fixes #12666.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
---

diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
index af41b8d2bd..ab427879e9 100644
--- a/html/cgi-bin/qos.cgi
+++ b/html/cgi-bin/qos.cgi
@@ -534,7 +534,7 @@ elsif ($qossettings{'ACTION'} eq $Lang::tr{'status'} )
 	if ($qossettings{'ENABLED'} eq 'on'){
 		my $output = "";
 		my @output = &General::system_output("/usr/local/bin/qosctrl", "status");
-		$output = &Header::cleanhtml(@output[0],"y");
+		$output = &Header::cleanhtml(join("", @output), "y");
 		print "<pre>$output</pre>\n";
 	} else { print "$Lang::tr{'QoS not enabled'}"; }
 	&Header::closebox();