From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 12 Jun 2021 16:37:52 +0000 (+0200)
Subject: asyn-ares: remove check for 'data' in Curl_resolver_cancel
X-Git-Tag: curl-7_78_0~143
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c4b8ec495d534e15e919c0e47b7e2d3086443ccf;p=thirdparty%2Fcurl.git

asyn-ares: remove check for 'data' in Curl_resolver_cancel

It implied it would survive a NULL in there which it won't. Instead do
an assert.

Pointed out by scan-build.

Closes #7248
---

diff --git a/lib/asyn-ares.c b/lib/asyn-ares.c
index 9ee307beb0..839fabb86a 100644
--- a/lib/asyn-ares.c
+++ b/lib/asyn-ares.c
@@ -206,7 +206,8 @@ static void destroy_async_data(struct Curl_async *async);
  */
 void Curl_resolver_cancel(struct Curl_easy *data)
 {
-  if(data && data->state.async.resolver)
+  DEBUGASSERT(data);
+  if(data->state.async.resolver)
     ares_cancel((ares_channel)data->state.async.resolver);
   destroy_async_data(&data->state.async);
 }