From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 4 Jun 2021 08:12:43 +0000 (+0200)
Subject: CLEAUNUP: quic: Usage of a useless variable in qc_treat_rx_pkts()
X-Git-Tag: v2.5-dev8~126
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c4b93ea57d1ee8a886cf772ec824ad8f0c11f79f;p=thirdparty%2Fhaproxy.git

CLEAUNUP: quic: Usage of a useless variable in qc_treat_rx_pkts()

The usage of a <drop> variable is unnecessary here.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 0337558693..cb00c02fdc 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2468,13 +2468,7 @@ int qc_treat_rx_pkts(struct quic_enc_level *el, struct quic_conn_ctx *ctx)
 			            QUIC_EV_CONN_ELRXPKTS, ctx->conn, pkt);
 		}
 		else {
-			int drop;
-
-			drop = 0;
-			if (!qc_parse_pkt_frms(pkt, ctx, el))
-				drop = 1;
-
-			if (drop) {
+			if (!qc_parse_pkt_frms(pkt, ctx, el)) {
 				/* Drop the packet */
 				TRACE_PROTO("packet parsing failed -> dropped",
 				            QUIC_EV_CONN_ELRXPKTS, ctx->conn, pkt);