From: Jiapeng Chong Date: Fri, 21 Jan 2022 11:43:51 +0000 (+0800) Subject: btrfs: zoned: remove redundant initialization of to_add X-Git-Tag: v5.18-rc1~172^2~83 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c4bf190999953c26070a59172ed01b995521c5ed;p=thirdparty%2Fkernel%2Flinux.git btrfs: zoned: remove redundant initialization of to_add to_add is being initialized to len but this is never read as to_add is overwritten later on. Remove the redundant initialization. Cleans up the following clang-analyzer warning: fs/btrfs/extent-tree.c:2769:8: warning: Value stored to 'to_add' during its initialization is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot Reviewed-by: Nikolay Borisov Signed-off-by: Jiapeng Chong Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 96427b1ecac3e..b7b49b4eb68db 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -2766,12 +2766,11 @@ static int unpin_extent_range(struct btrfs_fs_info *fs_info, spin_unlock(&cache->lock); if (!readonly && return_free_space && global_rsv->space_info == space_info) { - u64 to_add = len; - spin_lock(&global_rsv->lock); if (!global_rsv->full) { - to_add = min(len, global_rsv->size - - global_rsv->reserved); + u64 to_add = min(len, global_rsv->size - + global_rsv->reserved); + global_rsv->reserved += to_add; btrfs_space_info_update_bytes_may_use(fs_info, space_info, to_add);