From: Jacek Anaszewski Date: Mon, 10 Dec 2018 09:29:57 +0000 (+0100) Subject: led: triggers: Break the for loop after default trigger is found X-Git-Tag: v5.0-rc1~172^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c4f7bd4a42758ed42cf7f7a5fd46e0b54ce23ad2;p=thirdparty%2Flinux.git led: triggers: Break the for loop after default trigger is found It is of no avail to continue iterating through registered triggers in the led_trigger_set_default() after the trigger to set has been found. Add "break" statement to fix this omission. Signed-off-by: Jacek Anaszewski Acked-by: Pavel Machek Signed-off-by: Krzysztof Kozlowski --- diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 17d73db1456eb..52b12e601ebe8 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -200,8 +200,10 @@ void led_trigger_set_default(struct led_classdev *led_cdev) down_read(&triggers_list_lock); down_write(&led_cdev->trigger_lock); list_for_each_entry(trig, &trigger_list, next_trig) { - if (!strcmp(led_cdev->default_trigger, trig->name)) + if (!strcmp(led_cdev->default_trigger, trig->name)) { led_trigger_set(led_cdev, trig); + break; + } } up_write(&led_cdev->trigger_lock); up_read(&triggers_list_lock);