From: Xiongfeng Wang Date: Fri, 18 Nov 2022 06:31:34 +0000 (+0800) Subject: perf/x86/intel/uncore: Fix reference count leak in sad_cfg_iio_topology() X-Git-Tag: v6.2-rc1~176^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c508eb042d9739bf9473526f53303721b70e9100;p=thirdparty%2Flinux.git perf/x86/intel/uncore: Fix reference count leak in sad_cfg_iio_topology() pci_get_device() will increase the reference count for the returned pci_dev, and also decrease the reference count for the input parameter *from* if it is not NULL. If we break the loop in sad_cfg_iio_topology() with 'dev' not NULL. We need to call pci_dev_put() to decrease the reference count. Since pci_dev_put() can handle the NULL input parameter, we can just add one pci_dev_put() right before 'return ret'. Fixes: c1777be3646b ("perf/x86/intel/uncore: Enable I/O stacks to IIO PMON mapping on SNR") Signed-off-by: Xiongfeng Wang Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Kan Liang Link: https://lore.kernel.org/r/20221118063137.121512-2-wangxiongfeng2@huawei.com --- diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c index b8f9bd150b424..b14d591835168 100644 --- a/arch/x86/events/intel/uncore_snbep.c +++ b/arch/x86/events/intel/uncore_snbep.c @@ -4743,6 +4743,8 @@ static int sad_cfg_iio_topology(struct intel_uncore_type *type, u8 *sad_pmon_map type->topology[die][stack_id].iio->pci_bus_no = dev->bus->number; } + pci_dev_put(dev); + return ret; }