From: Jeremy Thomas <bbxdesign@gmail.com>
Date: Wed, 31 Oct 2018 18:19:43 +0000 (+0000)
Subject: Fix #2154
X-Git-Tag: 0.7.3~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c50cc06e5ae8ea4cc558ca23f5de6fc5920d9e2a;p=thirdparty%2Fbulma.git

Fix #2154
---

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c28554d6..e6b28a7a6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@
 * #2157 Fix #1656 -> Allow border radius if only one `.control` in `.field`
 * #2091 Fix #2091 -> Remove CSS rule which causes `.tag.has-addons` to not work correctly
 * #2186 Fix #1130 -> Prevent `.dropdown` links underlining in `.message` component
+* Fix #2154 -> Move `.hero.is-fullheight-with-navbar` to `navbar.sass` file
 
 ### Deprecation
 
diff --git a/docs/css/bulma-docs.css b/docs/css/bulma-docs.css
index b33608ee2..8cf4540c2 100644
--- a/docs/css/bulma-docs.css
+++ b/docs/css/bulma-docs.css
@@ -7159,6 +7159,10 @@ a.navbar-item:hover, a.navbar-item.is-active,
   }
 }
 
+.hero.is-fullheight-with-navbar {
+  min-height: calc(100vh - 3.25rem);
+}
+
 .pagination {
   font-size: 1rem;
   margin: -0.25rem;
@@ -10265,10 +10269,6 @@ label.panel-block:hover {
   min-height: 100vh;
 }
 
-.hero.is-fullheight-with-navbar {
-  min-height: calc(100vh - 3.25rem);
-}
-
 .hero-video {
   overflow: hidden;
 }
diff --git a/sass/components/navbar.sass b/sass/components/navbar.sass
index f11153d3f..dc90dd9d3 100644
--- a/sass/components/navbar.sass
+++ b/sass/components/navbar.sass
@@ -420,3 +420,9 @@ a.navbar-item,
     &.is-active
       .navbar-link
         background-color: $navbar-item-hover-background-color
+
+// Combination
+
+.hero
+  &.is-fullheight-with-navbar
+    min-height: calc(100vh - #{$navbar-height})
diff --git a/sass/layout/hero.sass b/sass/layout/hero.sass
index db56b9f89..d988040b3 100644
--- a/sass/layout/hero.sass
+++ b/sass/layout/hero.sass
@@ -109,8 +109,6 @@
     min-height: 50vh
   &.is-fullheight
     min-height: 100vh
-  &.is-fullheight-with-navbar
-    min-height: calc(100vh - #{$navbar-height})
 
 // Components