From: Dan Carpenter Date: Thu, 22 Feb 2018 09:14:53 +0000 (+0300) Subject: iio temperature/mlx90632: silence a static checker warning X-Git-Tag: v4.17-rc1~124^2~205^2~43 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c50fadeff758d4cc6e1ed196f776ae3016b3e021;p=thirdparty%2Flinux.git iio temperature/mlx90632: silence a static checker warning This shouldn't affect runtime at all, but Smatch complains that we should check if mlx90632_read_ambient_raw() otherwise we "ambient_new_raw" can be uninitialized. drivers/iio/temperature/mlx90632.c:509 mlx90632_calc_ambient_dsp105() error: uninitialized symbol 'ambient_new_raw'. Signed-off-by: Dan Carpenter Acked-by: Crt Mori Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c index d695ab97d27fa..9851311aa3fdc 100644 --- a/drivers/iio/temperature/mlx90632.c +++ b/drivers/iio/temperature/mlx90632.c @@ -506,6 +506,8 @@ static int mlx90632_calc_ambient_dsp105(struct mlx90632_data *data, int *val) ret = mlx90632_read_ambient_raw(data->regmap, &ambient_new_raw, &ambient_old_raw); + if (ret < 0) + return ret; *val = mlx90632_calc_temp_ambient(ambient_new_raw, ambient_old_raw, PT, PR, PG, PO, Gb); return ret;