From: Su Hui <suhui@nfschina.com>
Date: Mon, 22 Apr 2024 03:42:44 +0000 (+0800)
Subject: wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()
X-Git-Tag: v6.10-rc1~153^2~48^2~33^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c511a9c12674d246916bb16c479d496b76983193;p=thirdparty%2Fkernel%2Flinux.git

wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

Clang Static Checker (scan-build) warns:

drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
Value stored to 'ret' is never read.

Return 'ret' rather than 'count' when 'ret' stores an error code.

Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log via tracing")
Signed-off-by: Su Hui <suhui@nfschina.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240422034243.938962-1-suhui@nfschina.com
---

diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
index 394bf3c32abff..0f6de862c3a9b 100644
--- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c
+++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
@@ -439,7 +439,7 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file *file,
 	}
 out:
 	mutex_unlock(&ar->conf_mutex);
-	return count;
+	return ret ?: count;
 }
 
 static const struct file_operations fops_peer_debug_trigger = {