From: Juan Quintela <quintela@redhat.com>
Date: Tue, 24 Jul 2012 12:00:13 +0000 (+0200)
Subject: buffered_file: don't flush on put buffer
X-Git-Tag: v1.4.0-rc0~280^2~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c518dd841deb85b3ccf77ff93e1142b27b06af32;p=thirdparty%2Fqemu.git

buffered_file: don't flush on put buffer

We call buffered_put_buffer with iothread held, and buffered_flush() does
synchronous writes.  We only want to do the synchronous writes outside.

Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/buffered_file.c b/buffered_file.c
index d61d805de7d..1d7fa2443db 100644
--- a/buffered_file.c
+++ b/buffered_file.c
@@ -106,12 +106,6 @@ static int buffered_put_buffer(void *opaque, const uint8_t *buf, int64_t pos, in
         buffered_append(s, buf, size);
     }
 
-    error = buffered_flush(s);
-    if (error < 0) {
-        DPRINTF("buffered flush error. bailing: %s\n", strerror(-error));
-        return error;
-    }
-
     return size;
 }