From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Wed, 2 May 2018 00:25:32 +0000 (+0000)
Subject: packfile: remove unused member from struct pack_entry
X-Git-Tag: v2.18.0-rc0~17^2~38
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c51c39418bb754c7884be4d7dcef93ecab967c40;p=thirdparty%2Fgit.git

packfile: remove unused member from struct pack_entry

The sha1 member in struct pack_entry is unused except for one instance
in which we store a value in it.  Since nobody ever reads this value,
don't bother to compute it and remove the member from struct pack_entry.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/cache.h b/cache.h
index 11a989319d..dd1a9c6094 100644
--- a/cache.h
+++ b/cache.h
@@ -1572,7 +1572,6 @@ struct pack_window {
 
 struct pack_entry {
 	off_t offset;
-	unsigned char sha1[20];
 	struct packed_git *p;
 };
 
diff --git a/packfile.c b/packfile.c
index 0bc67d0e00..5c219d0229 100644
--- a/packfile.c
+++ b/packfile.c
@@ -1833,7 +1833,6 @@ static int fill_pack_entry(const unsigned char *sha1,
 		return 0;
 	e->offset = offset;
 	e->p = p;
-	hashcpy(e->sha1, sha1);
 	return 1;
 }