From: Thibault Godouet <yo8192@users.noreply.github.com>
Date: Mon, 5 Jun 2006 21:20:41 +0000 (+0000)
Subject: *** empty log message ***
X-Git-Tag: ver3_0_2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c6297001717ba6338320534ffb116d6fa18d1bcf;p=thirdparty%2Ffcron.git

*** empty log message ***
---

diff --git a/doc/en/changes.sgml b/doc/en/changes.sgml
index 3566c77..ab3e324 100644
--- a/doc/en/changes.sgml
+++ b/doc/en/changes.sgml
@@ -8,7 +8,7 @@ Foundation.
 A copy of the license is included in gfdl.sgml.
 -->
 
-<!-- $Id: changes.sgml,v 1.47 2006-06-05 20:03:40 thib Exp $ -->
+<!-- $Id: changes.sgml,v 1.48 2006-06-05 21:20:46 thib Exp $ -->
 
    <sect1 id="changes">
       <title>Changes</title>
@@ -18,6 +18,9 @@ A copy of the license is included in gfdl.sgml.
 	 <listitem>
 	    <para>Use sockaddr's field sa_len/sun_len on system defining it (BSD, ...). It should allow fcrondyn to connect to fcron on these systems.</para>
 	 </listitem>
+	 <listitem>
+	    <para>Run each job in a different session by calling setuid() for each one of them. This is to improve compatibility with Vixie cron.</para>
+	 </listitem>
 	 <listitem>
 	    <para>By default, don't use the shell defined in /etc/passwd by default, but use the default value form fcron.conf instead. This is for compatibility with Vixie cron.</para>
 	 </listitem>
diff --git a/fcrontab.c b/fcrontab.c
index 13355d9..0b982b5 100644
--- a/fcrontab.c
+++ b/fcrontab.c
@@ -21,7 +21,7 @@
  *  `LICENSE' that comes with the fcron source distribution.
  */
 
- /* $Id: fcrontab.c,v 1.70 2006-06-05 20:02:55 thib Exp $ */
+ /* $Id: fcrontab.c,v 1.71 2006-06-05 21:20:41 thib Exp $ */
 
 /* 
  * The goal of this program is simple : giving a user interface to fcron
@@ -46,7 +46,7 @@
 #include "temp_file.h"
 #include "read_string.h"
 
-char rcs_info[] = "$Id: fcrontab.c,v 1.70 2006-06-05 20:02:55 thib Exp $";
+char rcs_info[] = "$Id: fcrontab.c,v 1.71 2006-06-05 21:20:41 thib Exp $";
 
 void info(void);
 void usage(void);
@@ -1021,6 +1021,8 @@ main(int argc, char **argv)
     /* Open PAM session for the user and obtain any security
        credentials we might need */
 
+    /* FIXME: remove some #ifdef //////////////////////// */
+    /* FIXME: should really uid=euid when calling PAM ? */
 #ifdef USE_SETE_ID
     if (seteuid(uid) != 0) 
 	die_e("Could not change euid to %d", uid); 
@@ -1048,6 +1050,8 @@ main(int argc, char **argv)
     /* Close the log here, because PAM calls openlog(3) and
        our log messages could go to the wrong facility */
     xcloselog();
+    /* FIXME: remove some #ifdef //////////////////////// */
+    /* FIXME: should really uid=euid when calling PAM ? */
 #ifdef USE_SETE_ID
     if (seteuid(fcrontab_uid) != 0) 
 	die_e("Couldn't change euid to fcrontab_uid[%d]",fcrontab_uid);