From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Date: Fri, 21 Jul 2023 08:24:01 +0000 (+0200)
Subject: media: pci: saa7164: replace BUG with error return
X-Git-Tag: v6.6-rc1~97^2~246
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c62b089163ce89c7c0c471854ca01763c13813dd;p=thirdparty%2Fkernel%2Flinux.git

media: pci: saa7164: replace BUG with error return

It was completely unnecessary to use BUG in saa7164_s_frequency,
just return an error instead. This also solves a smatch error:

drivers/media/pci/saa7164/saa7164-encoder.c:388 saa7164_s_frequency() error: potentially dereferencing uninitialized 'tsport'.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---

diff --git a/drivers/media/pci/saa7164/saa7164-encoder.c b/drivers/media/pci/saa7164/saa7164-encoder.c
index c1b6a0596801c..bf73e9e83f523 100644
--- a/drivers/media/pci/saa7164/saa7164-encoder.c
+++ b/drivers/media/pci/saa7164/saa7164-encoder.c
@@ -383,7 +383,7 @@ int saa7164_s_frequency(struct saa7164_port *port,
 	else if (port->nr == SAA7164_PORT_ENC2)
 		tsport = &dev->ports[SAA7164_PORT_TS2];
 	else
-		BUG();
+		return -EINVAL; /* should not happen */
 
 	fe = tsport->dvb.frontend;