From: drh <drh@noemail.net>
Date: Mon, 31 Jul 2017 16:42:46 +0000 (+0000)
Subject: Move the generation of output column names earlier, to right after
X-Git-Tag: version-3.21.0~211
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c644980c4dca8caf3326d1a5c2a8d2b3b83c19e9;p=thirdparty%2Fsqlite.git

Move the generation of output column names earlier, to right after
name resolution and before query transformations such as flattening.
This prevents the names from getting mangled by query transformations,
and obviates hacks in the query flattener that attempt to work around
the name mangling. The resulting code is smaller and faster and gives
more consistent output. Fix to ticket [de3403bf5ae5f72ed].

FossilOrigin-Name: ade7ddf1998190b2b630715774963150d86bed3211b7fd600cbf3068427e1531
---

c644980c4dca8caf3326d1a5c2a8d2b3b83c19e9
diff --cc manifest
index f2fe31dd55,ea3d2d5936..a447242f02
--- a/manifest
+++ b/manifest
@@@ -1,5 -1,5 +1,5 @@@
- C Add\sthe\sschema6.test\smodule\sfor\sdemonstrating\sschemas\sthat\sgenerate\sidentical\nand\sdifferent\scontent.
- D 2017-07-30T19:50:42.416
 -C New\stest\scases\sfor\scolumn\sname\sgeneration\sinteracting\swith\sthe\squery\sflattener.
 -D 2017-07-29T17:02:22.699
++C Move\sthe\sgeneration\sof\soutput\scolumn\snames\searlier,\sto\sright\safter\nname\sresolution\sand\sbefore\squery\stransformations\ssuch\sas\sflattening.\s\nThis\sprevents\sthe\snames\sfrom\sgetting\smangled\sby\squery\stransformations,\s\nand\sobviates\shacks\sin\sthe\squery\sflattener\sthat\sattempt\sto\swork\saround\s\nthe\sname\smangling.\sThe\sresulting\scode\sis\ssmaller\sand\sfaster\sand\sgives\nmore\sconsistent\soutput.\sFix\sto\sticket\s[de3403bf5ae5f72ed].
++D 2017-07-31T16:42:46.666
  F Makefile.in d9873c9925917cca9990ee24be17eb9613a668012c85a343aef7e5536ae266e8
  F Makefile.linux-gcc 7bc79876b875010e8c8f9502eb935ca92aa3c434
  F Makefile.msc 02b469e9dcd5b7ee63fc1fb05babc174260ee4cfa4e0ef2e48c3c6801567a016
@@@ -1638,7 -1637,7 +1638,8 @@@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a9
  F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
  F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
  F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
- P 5216bfb73f1a49bdd879d470de139bf46a212474eaf6f38ad2390536d66a2afd
- R fcd196b2f8d80f06448991a0e133e88e
 -P 09834279aeca3bda63de684a369ed64f2cbf587b5f5df1454c0a3c009a1337ad
 -R 67883e010f09f35ff4da8532a7b615d9
++P ac1da06a829051d393ccb8bb986e78f5bd35b060687688f6b3661913b13c9a5a 0c38dde4543d6183a6ab0b7b3b75819f56c47704756a2426d54d3f20468d78d8
++R 676501af990a50a3769271a58903b891
++T +closed 0c38dde4543d6183a6ab0b7b3b75819f56c47704756a2426d54d3f20468d78d8
  U drh
- Z e76a816e9e2c5e050973bdc6741b8e4d
 -Z d8a6008eca97bd8ffc0a711cdb6dfcd3
++Z af511cee2e586dfefe9456d8226f20b4
diff --cc manifest.uuid
index 2dc32f1a04,9e8657dbe9..e887d876e8
--- a/manifest.uuid
+++ b/manifest.uuid
@@@ -1,1 -1,1 +1,1 @@@
- ac1da06a829051d393ccb8bb986e78f5bd35b060687688f6b3661913b13c9a5a
 -0c38dde4543d6183a6ab0b7b3b75819f56c47704756a2426d54d3f20468d78d8
++ade7ddf1998190b2b630715774963150d86bed3211b7fd600cbf3068427e1531