From: Pauli <pauli@openssl.org>
Date: Mon, 31 May 2021 04:29:34 +0000 (+1000)
Subject: store: remove TODOs
X-Git-Tag: openssl-3.0.0-beta1~251
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c6472fec64d83a196e1ccc4636b552bf0f23addd;p=thirdparty%2Fopenssl.git

store: remove TODOs

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15539)
---

diff --git a/crypto/store/store_local.h b/crypto/store/store_local.h
index 4d29857620d..6aeaaa915f3 100644
--- a/crypto/store/store_local.h
+++ b/crypto/store/store_local.h
@@ -54,7 +54,7 @@ struct ossl_store_search_st {
      * Used by OSSL_STORE_SEARCH_BY_NAME and
      * OSSL_STORE_SEARCH_BY_ISSUER_SERIAL
      */
-    X509_NAME *name; /* TODO constify this; leads to API incompatibility */
+    X509_NAME *name;
 
     /* Used by OSSL_STORE_SEARCH_BY_ISSUER_SERIAL */
     const ASN1_INTEGER *serial;
diff --git a/crypto/store/store_result.c b/crypto/store/store_result.c
index c78d96d5321..91c679718c5 100644
--- a/crypto/store/store_result.c
+++ b/crypto/store/store_result.c
@@ -399,8 +399,6 @@ static int try_key(struct extracted_param_data_st *data, OSSL_STORE_INFO **v,
              * engine provided legacy key.
              * This is the same as der2key_decode() does, but in a limited
              * way and within the walls of libcrypto.
-             *
-             * TODO Remove this when #legacy keys are gone
              */
             if (pk == NULL)
                 pk = try_key_value_legacy(data, &store_info_new, ctx,