From: Christopher Faulet <cfaulet@haproxy.com>
Date: Tue, 4 Apr 2023 08:06:57 +0000 (+0200)
Subject: BUG/MEDIUM: stconn: Add a missing return statement in sc_app_shutr()
X-Git-Tag: v2.8-dev7~104
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c665bb5637959be282226bd55ce372e1d2244db3;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: stconn: Add a missing return statement in sc_app_shutr()

In the commut b08c5259e ("MINOR: stconn: Always report READ/WRITE event on
shutr/shutw"), a return statement was erroneously removed from
sc_app_shutr(). As a consequence, CF_SHUTR flags was never set. Fortunately,
it is the default .shutr callback function. Thus when a connection or an
applet is attached to the SC, another callback is used to performe a
shutdown for reads.

It is a 28-dev specific issue. No backport needed.
---

diff --git a/src/stconn.c b/src/stconn.c
index 1e796c2642..3e6962e32d 100644
--- a/src/stconn.c
+++ b/src/stconn.c
@@ -537,7 +537,7 @@ static void sc_app_shutr(struct stconn *sc)
 	struct channel *ic = sc_ic(sc);
 
 	if (ic->flags & CF_SHUTR)
-
+		return;
 	ic->flags |= CF_SHUTR|CF_READ_EVENT;
 	sc_ep_report_read_activity(sc);