From: ed@s5h.net <ed@s5h.net>
Date: Sat, 7 Mar 2020 16:49:17 +0000 (+0000)
Subject: Fix segfault when time is unreadable
X-Git-Tag: v4.9~89^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c667083c8172727823fc2ca380db7496f1df1938;p=thirdparty%2Fshadow.git

Fix segfault when time is unreadable

Adding myself to contributors

Closes #130
---

diff --git a/README b/README
index c0c03f2d8..cf54ca8e3 100644
--- a/README
+++ b/README
@@ -59,6 +59,7 @@ Dave Hagewood <admin@arrowweb.com>
 David A. Holland <dholland@hcs.harvard.edu>
 David Frey <David.Frey@lugs.ch>
 Ed Carp <ecarp@netcom.com>
+Ed Neville <ed@s5h.net>
 Eric W. Biederman" <ebiederm@xmission.com>
 Floody <flood@evcom.net>
 Frank Denis <j@4u.net>
diff --git a/src/faillog.c b/src/faillog.c
index 1309dad4f..3ab48db36 100644
--- a/src/faillog.c
+++ b/src/faillog.c
@@ -163,6 +163,10 @@ static void print_one (/*@null@*/const struct passwd *pw, bool force)
 	}
 
 	tm = localtime (&fl.fail_time);
+	if (!tm) {
+		fprintf (stderr, "Cannot read time from faillog.\n");
+		exit (EXIT_FAILURE);
+	}
 #ifdef HAVE_STRFTIME
 	strftime (ptime, sizeof (ptime), "%D %H:%M:%S %z", tm);
 	cp = ptime;