From: Eric Blake <eblake@redhat.com>
Date: Mon, 13 Jun 2011 21:20:03 +0000 (-0600)
Subject: command: reduce duplicated debug messages
X-Git-Tag: v0.9.3-rc1~172
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c668c89778f7ea8ee235dc89e8fb08990485d91b;p=thirdparty%2Flibvirt.git

command: reduce duplicated debug messages

This also reduces malloc pressure for invoking a child when
VIR_DEBUG is enabled.

* src/util/command.c (virExecWithHook): Drop debug, since the only
caller (virCommandRunAsync) also prints debug info.
---

diff --git a/src/util/command.c b/src/util/command.c
index 0f8ff14acc..11443922c9 100644
--- a/src/util/command.c
+++ b/src/util/command.c
@@ -296,26 +296,6 @@ virExecWithHook(const char *const*argv,
     int tmpfd;
     const char *binary = NULL;
     int forkRet;
-    char *argv_str = NULL;
-    char *envp_str = NULL;
-
-    if ((argv_str = virArgvToString(argv)) == NULL) {
-        virReportOOMError();
-        return -1;
-    }
-
-    if (envp) {
-        if ((envp_str = virArgvToString(envp)) == NULL) {
-            VIR_FREE(argv_str);
-            virReportOOMError();
-            return -1;
-        }
-        VIR_DEBUG("%s %s", envp_str, argv_str);
-        VIR_FREE(envp_str);
-    } else {
-        VIR_DEBUG("%s", argv_str);
-    }
-    VIR_FREE(argv_str);
 
     if (argv[0][0] != '/') {
         if (!(binary = virFindFileInPath(argv[0]))) {