From: Tom Rix Date: Mon, 18 Apr 2022 15:28:10 +0000 (-0400) Subject: drm/nouveau/gr/gf100-: change gf108_gr_fwif from global to static X-Git-Tag: v5.19-rc1~153^2~19^2~27 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c6ed9f66eb70aeaac9998bd3552ada740d90e20c;p=thirdparty%2Fkernel%2Flinux.git drm/nouveau/gr/gf100-: change gf108_gr_fwif from global to static Smatch reports this issue gf108.c:147:1: warning: symbol 'gf108_gr_fwif' was not declared. Should it be static? gf108_gr_fwif is only used in gf108.c. Single file variables should not be global so change gf108_gr_fwif's storage-class specifier to static. Signed-off-by: Tom Rix Reviewed-by: Lyude Paul Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop.org/patch/msgid/20220418152810.3280502-1-trix@redhat.com --- diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c index 030640bb3dca0..ab3760e804b8a 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c @@ -143,7 +143,7 @@ gf108_gr = { } }; -const struct gf100_gr_fwif +static const struct gf100_gr_fwif gf108_gr_fwif[] = { { -1, gf100_gr_load, &gf108_gr }, { -1, gf100_gr_nofw, &gf108_gr },