From: Geert Uytterhoeven Date: Wed, 14 Jan 2015 13:51:59 +0000 (+0100) Subject: backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount hack X-Git-Tag: v4.1-rc1~136^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c6f77bc2b3f9512fd8d637a45060408061a035a9;p=thirdparty%2Flinux.git backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount hack of_find_node_by_name() calls of_node_put() on its "from" parameter. To counter this, pm860x_backlight_dt_init() calls of_node_get() first. Use of_get_child_by_name() instead to get rid of the refcount hack. Signed-off-by: Geert Uytterhoeven Signed-off-by: Lee Jones --- diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c index 9a23698b6fe83..2da5862876d1f 100644 --- a/drivers/video/backlight/88pm860x_bl.c +++ b/drivers/video/backlight/88pm860x_bl.c @@ -168,10 +168,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, struct device_node *nproot, *np; int iset = 0; - nproot = of_node_get(pdev->dev.parent->of_node); - if (!nproot) - return -ENODEV; - nproot = of_find_node_by_name(nproot, "backlights"); + nproot = of_get_child_by_name(pdev->dev.parent->of_node, "backlights"); if (!nproot) { dev_err(&pdev->dev, "failed to find backlights node\n"); return -ENODEV;