From: Ed Blake Date: Mon, 2 Oct 2017 10:00:33 +0000 (+0100) Subject: ASoC: img-parallel-out: Add pm_runtime_get/put to set_fmt callback X-Git-Tag: v4.15-rc1~118^2~1^2~5^3~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c70458890ff15d858bd347fa9f563818bcd6e457;p=thirdparty%2Fkernel%2Flinux.git ASoC: img-parallel-out: Add pm_runtime_get/put to set_fmt callback Add pm_runtime_get_sync and pm_runtime_put calls to set_fmt callback function. This fixes a bus error during boot when CONFIG_SUSPEND is defined when this function gets called while the device is runtime disabled and device registers are accessed while the clock is disabled. Signed-off-by: Ed Blake Signed-off-by: Mark Brown --- diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c index 23b0f0f6ec9cb..2fc8a63722060 100644 --- a/sound/soc/img/img-parallel-out.c +++ b/sound/soc/img/img-parallel-out.c @@ -164,9 +164,11 @@ static int img_prl_out_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + pm_runtime_get_sync(prl->dev); reg = img_prl_out_readl(prl, IMG_PRL_OUT_CTL); reg = (reg & ~IMG_PRL_OUT_CTL_EDGE_MASK) | control_set; img_prl_out_writel(prl, reg, IMG_PRL_OUT_CTL); + pm_runtime_put(prl->dev); return 0; }