From: Martti Rannanjärvi <martti.rannanjarvi@dovecot.fi>
Date: Tue, 11 Sep 2018 08:21:36 +0000 (+0300)
Subject: driver-sqlite: Fix crash and event leak in driver_sqlite_query_s()
X-Git-Tag: 2.3.4~77
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c71040bfe28c11cda8e1ca27b02816aaa4a641a9;p=thirdparty%2Fdovecot%2Fcore.git

driver-sqlite: Fix crash and event leak in driver_sqlite_query_s()
---

diff --git a/src/lib-sql/driver-sqlite.c b/src/lib-sql/driver-sqlite.c
index 4cbaa8ae97..30fb575e92 100644
--- a/src/lib-sql/driver-sqlite.c
+++ b/src/lib-sql/driver-sqlite.c
@@ -203,9 +203,14 @@ driver_sqlite_query_s(struct sql_db *_db, const char *query)
 {
 	struct sqlite_db *db = (struct sqlite_db *)_db;
 	struct sqlite_result *result;
+	struct event *event;
 
 	result = i_new(struct sqlite_result, 1);
-	result->api.event = event_create(_db->event);
+	result->api.db = _db;
+	/* Temporarily store the event since result->api gets
+	 * overwritten later here and we need to reset it. */
+	event = event_create(_db->event);
+	result->api.event = event;
 
 	if (driver_sqlite_connect(_db) < 0) {
 		driver_sqlite_result_log(&result->api, query);
@@ -225,9 +230,10 @@ driver_sqlite_query_s(struct sql_db *_db, const char *query)
 			result->cols = 0;
 		}
 	}
+
 	result->api.db = _db;
 	result->api.refcount = 1;
-
+	result->api.event = event;
 	return &result->api;
 }