From: Stefan Metzmacher Date: Wed, 28 May 2025 20:13:55 +0000 (+0200) Subject: lib/torture: directly remove the dummy signal event again to avoid flapping tests X-Git-Tag: tevent-0.17.0~60 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c716bf33a53b3f090c7e967da776958b1cd70b72;p=thirdparty%2Fsamba.git lib/torture: directly remove the dummy signal event again to avoid flapping tests I don't know why but commit 57a57a189bd9a7348656990b2c888a328b524bb0: lib/torture: assert that a test doesn't create new talloc children of context->ev introduced the regression thad lead to commit 3fa94d9f2fcb165d435c62badde9e3c8569ff40d: selftest: mark samba4.rpc.samr.passwords.lockout on ncacn_np with .samr.lockout as flapping Doing a TALLOC_FREE(dummy_se) still means we have the tevent_add_fd() from tevent_common_wakeup_init() cached as talloc child of tevent_context and that is all we need here and the test is not flagging anymore. Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Mon Jun 2 19:13:27 UTC 2025 on atb-devel-224 --- diff --git a/lib/torture/torture.c b/lib/torture/torture.c index 78caaa8c9ba..930b6036325 100644 --- a/lib/torture/torture.c +++ b/lib/torture/torture.c @@ -605,6 +605,7 @@ static bool internal_torture_run_test(struct torture_context *_context, TALLOC_FREE(frame); return false; } + TALLOC_FREE(dummy_se); evtb1 = talloc_total_blocks(context->ev); } @@ -728,6 +729,7 @@ bool torture_run_tcase_restricted(struct torture_context *_context, context = _context; goto setup_failed; } + TALLOC_FREE(dummy_se); evtb1 = talloc_total_blocks(context->ev); diff --git a/selftest/flapping.d/samba4.rpc.samr.passwords b/selftest/flapping.d/samba4.rpc.samr.passwords deleted file mode 100644 index 85618be9a08..00000000000 --- a/selftest/flapping.d/samba4.rpc.samr.passwords +++ /dev/null @@ -1 +0,0 @@ -^samba4.rpc.samr.passwords.lockout on ncacn_np with .samr.lockout\(ad_dc_slowtests\)