From: Philippe Mathieu-Daudé Date: Thu, 7 May 2020 12:11:28 +0000 (+0200) Subject: block/block-copy: Fix uninitialized variable in block_copy_task_entry X-Git-Tag: v5.1.0-rc0~120^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c78dd00e3529f923280e2ab51e60dfcdad2c6094;p=thirdparty%2Fqemu.git block/block-copy: Fix uninitialized variable in block_copy_task_entry Fix when building with -Os: CC block/block-copy.o block/block-copy.c: In function ‘block_copy_task_entry’: block/block-copy.c:428:38: error: ‘error_is_read’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 428 | t->call_state->error_is_read = error_is_read; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~ Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200507121129.29760-2-philmd@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- diff --git a/block/block-copy.c b/block/block-copy.c index 4713c8f2a3d..7c7f7acbae3 100644 --- a/block/block-copy.c +++ b/block/block-copy.c @@ -418,7 +418,7 @@ out: static coroutine_fn int block_copy_task_entry(AioTask *task) { BlockCopyTask *t = container_of(task, BlockCopyTask, task); - bool error_is_read; + bool error_is_read = false; int ret; ret = block_copy_do_copy(t->s, t->offset, t->bytes, t->zeroes,