From: Javier Carrasco Date: Mon, 24 Jun 2024 21:10:06 +0000 (+0200) Subject: usb: core: add missing of_node_put() in usb_of_has_devices_or_graph X-Git-Tag: v6.10~14^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c7a5403ea04320e08f2595baa940541a59a3856e;p=thirdparty%2Fkernel%2Flinux.git usb: core: add missing of_node_put() in usb_of_has_devices_or_graph The for_each_child_of_node() macro requires an explicit call to of_node_put() on early exits to decrement the child refcount and avoid a memory leak. The child node is not required outsie the loop, and the resource must be released before the function returns. Add the missing of_node_put(). Cc: stable@vger.kernel.org Fixes: 82e82130a78b ("usb: core: Set connect_type of ports based on DT node") Signed-off-by: Javier Carrasco Reviewed-by: Stephen Boyd Link: https://lore.kernel.org/r/20240624-usb_core_of_memleak-v1-1-af6821c1a584@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c index f1a499ee482c3..763e4122ed5b3 100644 --- a/drivers/usb/core/of.c +++ b/drivers/usb/core/of.c @@ -84,9 +84,12 @@ static bool usb_of_has_devices_or_graph(const struct usb_device *hub) if (of_graph_is_present(np)) return true; - for_each_child_of_node(np, child) - if (of_property_present(child, "reg")) + for_each_child_of_node(np, child) { + if (of_property_present(child, "reg")) { + of_node_put(child); return true; + } + } return false; }