From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 24 Mar 2016 08:35:05 +0000 (+1300)
Subject: Add memFindStringSizeType() to simplify looking up a string pool
X-Git-Tag: SQUID_4_0_8~20^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c7ae4a7cc1fe76760be12c70e398d3d8e70331ff;p=thirdparty%2Fsquid.git

Add memFindStringSizeType() to simplify looking up a string pool
---

diff --git a/src/mem/old_api.cc b/src/mem/old_api.cc
index 8217827560..ca89209cd7 100644
--- a/src/mem/old_api.cc
+++ b/src/mem/old_api.cc
@@ -119,6 +119,27 @@ GetStrPool(size_t type)
     return strPools[type];
 }
 
+/* Find the best fit string pool type */
+static mem_type
+memFindStringSizeType(size_t net_size, bool fuzzy)
+{
+    mem_type type = MEM_NONE;
+    for (unsigned int i = 0; i < mem_str_pool_count; ++i) {
+        auto pool = GetStrPool(i);
+        if (!pool)
+            continue;
+        if (fuzzy && net_size < pool->objectSize()) {
+            type = static_cast<mem_type>(i);
+            break;
+        } else if (net_size == pool->objectSize()) {
+            type = static_cast<mem_type>(i);
+            break;
+        }
+    }
+
+    return type;
+}
+
 static void
 memStringStats(std::ostream &stream)
 {
@@ -230,15 +251,11 @@ memAllocString(size_t net_size, size_t * gross_size)
     if (!MemIsInitialized && net_size < SmallestStringBeforeMemIsInitialized)
         net_size = SmallestStringBeforeMemIsInitialized;
 
-    unsigned int i;
-    for (i = 0; i < mem_str_pool_count; ++i) {
-        if (net_size <= StrPoolsAttrs[i].obj_size) {
-            pool = GetStrPool(i);
-            break;
-        }
-    }
+    auto type = memFindStringSizeType(net_size, true);
+    if (type != MEM_NONE)
+        pool = GetStrPool(type);
 
-    *gross_size = pool ? StrPoolsAttrs[i].obj_size : net_size;
+    *gross_size = pool ? pool->objectSize() : net_size;
     assert(*gross_size >= net_size);
     // may forget [de]allocations until MemIsInitialized
     ++StrCountMeter;
@@ -264,15 +281,9 @@ memFreeString(size_t size, void *buf)
     MemAllocator *pool = NULL;
     assert(buf);
 
-    if (MemIsInitialized) {
-        for (unsigned int i = 0; i < mem_str_pool_count; ++i) {
-            if (size <= StrPoolsAttrs[i].obj_size) {
-                assert(size == StrPoolsAttrs[i].obj_size);
-                pool = GetStrPool(i);
-                break;
-            }
-        }
-    }
+    auto type = memFindStringSizeType(size, false);
+    if (type != MEM_NONE)
+        pool = GetStrPool(type);
 
     // may forget [de]allocations until MemIsInitialized
     --StrCountMeter;