From: Jouni Malinen <jouni@codeaurora.org>
Date: Tue, 11 Feb 2020 04:33:24 +0000 (+0200)
Subject: DPP: Reset DPP_AUTH_INIT netrole back to STA by default
X-Git-Tag: hostap_2_10~1850
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c7cc80fbc8f917f239fbc6280b1e4dbe96c8372d;p=thirdparty%2Fhostap.git

DPP: Reset DPP_AUTH_INIT netrole back to STA by default

Previously DPP_AUTH_INIT command update wpa_s->dpp_netrole only if the
netrole parameter was included. This could leave AP or configurator
network in place for the next DPP_AUTH_INIT command. This would be
unexpected behavior, so reset wpa_s->dpp_netrole back to the
DPP_NETROLE_STA default if no explicit netrole parameter is included.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
---

diff --git a/wpa_supplicant/dpp_supplicant.c b/wpa_supplicant/dpp_supplicant.c
index 0811ab300..0a13213b0 100644
--- a/wpa_supplicant/dpp_supplicant.c
+++ b/wpa_supplicant/dpp_supplicant.c
@@ -751,6 +751,8 @@ int wpas_dpp_auth_init(struct wpa_supplicant *wpa_s, const char *cmd)
 			wpa_s->dpp_netrole = DPP_NETROLE_CONFIGURATOR;
 		else
 			wpa_s->dpp_netrole = DPP_NETROLE_STA;
+	} else {
+		wpa_s->dpp_netrole = DPP_NETROLE_STA;
 	}
 
 	pos = os_strstr(cmd, " neg_freq=");