From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 10 Feb 2010 19:47:28 +0000 (+0100)
Subject: monitor: Use argument type 'O' for device_add
X-Git-Tag: v0.13.0-rc0~1079^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c7e4e8ceb379e15c8cb79427f10169b2ccaa8de6;p=thirdparty%2Fqemu.git

monitor: Use argument type 'O' for device_add

While there, improve the params help text.
---

diff --git a/hw/qdev.c b/hw/qdev.c
index 64cabd55a27..a28e2623e9f 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -766,8 +766,7 @@ void do_device_add(Monitor *mon, const QDict *qdict)
 {
     QemuOpts *opts;
 
-    opts = qemu_opts_parse(&qemu_device_opts,
-                           qdict_get_str(qdict, "config"), 1);
+    opts = qemu_opts_from_qdict(&qemu_device_opts, qdict);
     if (opts) {
         if (qdev_device_help(opts) || qdev_device_add(opts) == NULL) {
             qemu_opts_del(opts);
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 7f9d261cd9a..45e5fd10f3a 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -570,8 +570,8 @@ ETEXI
 
     {
         .name       = "device_add",
-        .args_type  = "config:s",
-        .params     = "device",
+        .args_type  = "device:O",
+        .params     = "driver[,prop=value][,...]",
         .help       = "add device, like -device on the command line",
         .mhandler.cmd = do_device_add,
     },