From: Hans de Goede <hdegoede@redhat.com>
Date: Sun, 22 Apr 2018 17:57:59 +0000 (+0200)
Subject: i2c: core: ACPI: Improve OpRegion read errors
X-Git-Tag: v4.17-rc6~18^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c8016fa215d2d50920a58de07da2d00f7cb982f3;p=thirdparty%2Fkernel%2Flinux.git

i2c: core: ACPI: Improve OpRegion read errors

When we get an error doing an ACPI SerialBus I2C OpRegion read log some
useful details, like the client address and which register is being
read.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index a9126b3cda61b..3dc43a009f5d7 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -446,7 +446,8 @@ static int acpi_gsb_i2c_read_bytes(struct i2c_client *client,
 
 	ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
 	if (ret < 0)
-		dev_err(&client->adapter->dev, "i2c read failed\n");
+		dev_err(&client->adapter->dev, "i2c read %d bytes from client@%#x starting at reg %#x failed, error: %d\n",
+			data_len, client->addr, cmd, ret);
 	else
 		memcpy(data, buffer, data_len);