From: Karel Zak <kzak@redhat.com>
Date: Mon, 6 Nov 2023 10:40:27 +0000 (+0100)
Subject: libmount: fix possible NULL dereference [coverity scan]
X-Git-Tag: v2.40-rc1~167
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c8448495049b22e6ee30c84c377e61f65d886ca3;p=thirdparty%2Futil-linux.git

libmount: fix possible NULL dereference [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/libmount/src/tab.c b/libmount/src/tab.c
index 5c2d5c868b..972566467b 100644
--- a/libmount/src/tab.c
+++ b/libmount/src/tab.c
@@ -660,7 +660,7 @@ int mnt_table_next_child_fs(struct libmnt_table *tb, struct libmnt_iter *itr,
 {
 	struct libmnt_fs *fs, *chfs = NULL;
 	int parent_id, lastchld_id = 0, chld_id = 0;
-	int direction = mnt_iter_get_direction(itr);
+	int direction;
 
 	if (!tb || !itr || !parent || !is_mountinfo(tb))
 		return -EINVAL;
@@ -668,6 +668,7 @@ int mnt_table_next_child_fs(struct libmnt_table *tb, struct libmnt_iter *itr,
 	DBG(TAB, ul_debugobj(tb, "lookup next child of '%s'",
 				mnt_fs_get_target(parent)));
 	parent_id = mnt_fs_get_id(parent);
+	direction = mnt_iter_get_direction(itr);
 
 	/* get ID of the previously returned child */
 	if (itr->head && itr->p != itr->head) {